Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Add brew libs to RUSTFLAGS in aarch64 #5218

Merged
merged 1 commit into from
Nov 5, 2024
Merged

fix(ci): Add brew libs to RUSTFLAGS in aarch64 #5218

merged 1 commit into from
Nov 5, 2024

Conversation

xdoardo
Copy link
Contributor

@xdoardo xdoardo commented Nov 5, 2024

As per title.

@xdoardo xdoardo linked an issue Nov 5, 2024 that may be closed by this pull request
Fix library 'zstd' not found aarch64 build issue with LLVM #5217
Closed
@xdoardo xdoardo requested a review from maminrayej November 5, 2024 17:29
maminrayej
maminrayej approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@maminrayej maminrayej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd use something like startsWith(matrix.build, 'macos-arm'), but LGTM.

@xdoardo xdoardo merged commit 164db65 into main Nov 5, 2024
71 of 72 checks passed
@xdoardo xdoardo deleted the 5217-fix-aarch64-build-issue-with-llvm branch November 5, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maminrayej maminrayej maminrayej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix library 'zstd' not found aarch64 build issue with LLVM
2 participants
@xdoardo @maminrayej