Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve networking in emscripten #519

Merged
merged 3 commits into from
Jul 2, 2019
Merged

improve networking in emscripten #519

merged 3 commits into from
Jul 2, 2019

Conversation

MarkMcCaskey
Copy link
Contributor

Adds a null check to WasmPtr, improves networking in Emscripten, implements poll

@MarkMcCaskey MarkMcCaskey added 📦 lib-emscripten About wasmer-emscripten 📦 lib-deprecated About the deprecated crates labels Jul 1, 2019
@MarkMcCaskey MarkMcCaskey requested a review from syrusakbary July 1, 2019 23:37
@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Jul 1, 2019
@bors
Try #519:
0ca02ed
@bors
Copy link
Contributor

bors bot commented Jul 1, 2019

try

Build failed

@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Jul 1, 2019
@bors
Try #519:
1797584
@bors
Copy link
Contributor

bors bot commented Jul 2, 2019

try

Build failed

@MarkMcCaskey
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Jul 2, 2019
@bors
Merge #519
fc9398e 
519: improve networking in emscripten r=MarkMcCaskey a=MarkMcCaskey

Adds a null check to WasmPtr, improves networking in Emscripten, implements poll

Co-authored-by: Mark McCaskey <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jul 2, 2019

Build succeeded

@bors bors bot merged commit d407606 into master Jul 2, 2019
@bors bors bot deleted the feature/further-improve-networking-in-emscripten branch July 2, 2019 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
📦 lib-deprecated About the deprecated crates 📦 lib-emscripten About wasmer-emscripten
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkMcCaskey @syrusakbary