Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve double-free error in c-api #5156

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Resolve double-free error in c-api #5156

merged 3 commits into from
Oct 18, 2024

Conversation

xdoardo
Copy link
Contributor

@xdoardo xdoardo commented Oct 18, 2024

As per title.

The previous signature took ownership of the value, causing it to be release entirely. Now, we release the pointee, but not the pointer itself.

Closes #5141

@xdoardo xdoardo requested a review from syrusakbary as a code owner October 18, 2024 13:13
@syrusakbary syrusakbary merged commit 8b97cfe into main Oct 18, 2024
70 of 72 checks passed
@syrusakbary syrusakbary deleted the c-api-doublefree branch October 18, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wasmer-c-api: wasm_val_delete causes double free error
2 participants