Terminate entire wasix process when a worker thread fails or calls exit #5153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theduke
reviewed
Oct 18, 2024
…exit with a success code
Arshia001
force-pushed
the
fix/wasix-thread-panic
branch
from
5a09815 to
f5a5e65
Compare
theduke
reviewed
Oct 21, 2024
theduke
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5130.
On native platforms, when a thread causes a segfault, panics, calls
exit(), or otherwise terminates abnormally, the entire process will exit. This was not the case on WASIX before, but should now be the case with this PR.