Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rkyv #5142

Merged
merged 39 commits into from
Oct 15, 2024
Merged

Upgrade rkyv #5142

merged 39 commits into from
Oct 15, 2024

Conversation

xdoardo
Copy link
Contributor

@xdoardo xdoardo commented Oct 10, 2024

This patch bumps the version of rkyv used throughout the codebase from 0.7.x to 0.8.x.

Note: many of the failing CI tests are to be resolved as-we-go in the current effort for 5.0.

@xdoardo xdoardo requested a review from syrusakbary as a code owner October 10, 2024 11:34
@xdoardo xdoardo requested a review from theduke October 10, 2024 11:37
lib/types/src/serialize.rs Show resolved Hide resolved
@theduke
Copy link
Contributor

theduke commented Oct 14, 2024

I only looked at the journal crate.
The changes there look good to me.

When the version bump mentioned is resolved, this PR should be good to go from my end, but I'm not approving because I have not reviewed any of the other code.

@xdoardo xdoardo linked an issue Oct 14, 2024 that may be closed by this pull request
@xdoardo xdoardo merged commit 5ac7dbf into release-5.0 Oct 15, 2024
60 of 66 checks passed
@xdoardo xdoardo deleted the update-rkyv branch October 15, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update rkyv
3 participants