Fix lseek in emscripten #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/emscripten/src/syscalls/mod.rs
Outdated
| let offset_low: i32 = varargs.get(ctx); | ||
| let result_ptr_value = varargs.get::<i32>(ctx); | ||
| let result_ptr_value: i32 = varargs.get(ctx); |
There was a problem hiding this comment.
let memory = ctx.memory(0);
let result_ptr_value: WasmPtr<i64> = varargs.get(ctx).unwrap();
let result_ptr =result_ptr_value.deref(memory);
result_ptr.set(ret);
Will do what you want I think!
There was a problem hiding this comment.
and it doesn't need that assert or any of the emscripten_memory_pointer stuff
MarkMcCaskey
approved these changes
Jun 27, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 27, 2019
513: Fix lseek in emscripten r=syrusakbary a=syrusakbary Fix lseek in emscripten Co-authored-by: Syrus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix lseek in emscripten