Minor cleanup in LLVM backend. #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nlewycky
commented
Jun 25, 2019
nlewycky
commented
- Simplify construction of floating point constants
- Fix assertion failure due to definition of %ctx
… not form a pointer to void or use it as a structure member. Fixes assertion failure initializing llvm backend.
|
bors try |
|
Looks good to me. |
Hywan
approved these changes
Jun 26, 2019
Hywan
added
🎉 enhancement
|
@nlewycky Can you please update the |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 26, 2019
510: Minor cleanup in LLVM backend. r=Hywan a=nlewycky - Simplify construction of floating point constants - Fix assertion failure due to definition of %ctx Co-authored-by: Nick Lewycky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.