Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js::module: leave warning comment on the Send impl #5098

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

Twey
Copy link
Contributor

@Twey Twey commented Sep 18, 2024

Description

Until #4158 is fixed, let's at least leave a signpost so future readers don't trip on it like I did :)

Until wasmerio#4158 is fixed, let's at least leave a signpost so future readers don't trip on it like I did :)
@Twey Twey requested a review from syrusakbary as a code owner September 18, 2024 12:33
@syrusakbary
Copy link
Member

Modules should be Send, but we need to spend time to investigate why they were not working.
We can merge this until gets solved

@syrusakbary syrusakbary merged commit 3d638e4 into wasmerio:main Oct 3, 2024
62 of 63 checks passed
@Twey
Copy link
Contributor Author

Twey commented Oct 8, 2024

Modules should be Send, but we need to spend time to investigate why they were not working.
We can merge this until gets solved

I don't think that JavaScript modules can ever be Send, since we must always postMessage the JS object (or have some other explicit transfer step).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants