Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Restore packages from webcs #5089

Conversation

theduke
Copy link
Contributor

@theduke theduke commented Sep 15, 2024

Allow "package unpack" to restore packages

Add a new --format option to package unpack.

  • package: Try to restore a usable package dir with a wasmer.toml
  • webc: just unpack the webc

Also adds a new wasmer-package crate that can hold package related functionality.

As a drive-by chore, also lifts pretty_assertions to be a workspace dependency.

Closes #5085

@theduke theduke force-pushed the run-433-cli-allow-synthesizing-a-wasmertoml-in-wasmer-package-unpack branch 3 times, most recently from 7fc43be to 0b40116 Compare September 16, 2024 08:02
Convert webc images to a package directory with a wasmer.toml
Add a new --format option to package unpack.

* package: Try to restore a usable package dir with a wasmer.toml

* webc: just unpack the webc
@theduke theduke force-pushed the run-433-cli-allow-synthesizing-a-wasmertoml-in-wasmer-package-unpack branch from 0b40116 to bf40de3 Compare September 16, 2024 08:08
@maminrayej
Copy link
Contributor

Otherwise LGTM.

@theduke theduke force-pushed the run-433-cli-allow-synthesizing-a-wasmertoml-in-wasmer-package-unpack branch from f3a274f to 1336783 Compare September 16, 2024 10:52
…thesizing-a-wasmertoml-in-wasmer-package-unpack
@theduke theduke enabled auto-merge (rebase) September 16, 2024 10:55
auto-merge was automatically disabled September 16, 2024 11:38

Rebase failed

@theduke theduke merged commit ec528e4 into main Sep 16, 2024
62 of 63 checks passed
@theduke theduke deleted the run-433-cli-allow-synthesizing-a-wasmertoml-in-wasmer-package-unpack branch September 16, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI: allow synthesizing a wasmer.toml in "wasmer package unpack"
2 participants