-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): Restore packages from webcs #5089
Merged
theduke
merged 7 commits into
main
from
run-433-cli-allow-synthesizing-a-wasmertoml-in-wasmer-package-unpack
Sep 16, 2024
Merged
feat(cli): Restore packages from webcs #5089
theduke
merged 7 commits into
main
from
run-433-cli-allow-synthesizing-a-wasmertoml-in-wasmer-package-unpack
Sep 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The crate will hold package related logic.
theduke
force-pushed
the
run-433-cli-allow-synthesizing-a-wasmertoml-in-wasmer-package-unpack
branch
3 times, most recently
from
September 16, 2024 08:02
7fc43be
to
0b40116
Compare
Convert webc images to a package directory with a wasmer.toml
Add a new --format option to package unpack. * package: Try to restore a usable package dir with a wasmer.toml * webc: just unpack the webc
theduke
force-pushed
the
run-433-cli-allow-synthesizing-a-wasmertoml-in-wasmer-package-unpack
branch
from
September 16, 2024 08:08
0b40116
to
bf40de3
Compare
maminrayej
reviewed
Sep 16, 2024
maminrayej
reviewed
Sep 16, 2024
Otherwise LGTM. |
theduke
force-pushed
the
run-433-cli-allow-synthesizing-a-wasmertoml-in-wasmer-package-unpack
branch
from
September 16, 2024 10:52
f3a274f
to
1336783
Compare
maminrayej
approved these changes
Sep 16, 2024
…thesizing-a-wasmertoml-in-wasmer-package-unpack
auto-merge was automatically disabled
September 16, 2024 11:38
Rebase failed
theduke
deleted the
run-433-cli-allow-synthesizing-a-wasmertoml-in-wasmer-package-unpack
branch
September 16, 2024 12:15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow "package unpack" to restore packages
Add a new --format option to package unpack.
Also adds a new wasmer-package crate that can hold package related functionality.
As a drive-by chore, also lifts pretty_assertions to be a workspace dependency.
Closes #5085