Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Allow sorting in "app list" command #5025

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Conversation

theduke
Copy link
Contributor

@theduke theduke commented Aug 20, 2024

  • feat(backend-api): Allow sorting in app queries
  • feat(cli): Allow sorting in "app list" command

@theduke theduke requested a review from syrusakbary as a code owner August 20, 2024 10:41

/// Sort order for apps.
///
/// Use: --newest, --oldest or --last-updated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't clap print possible values already? Maybe it's different from ValueEnum'd enums.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It didn't use to, they might have added it.

@syrusakbary
Copy link
Member

We'll merge and solve the clap thing afterwards if needed

@syrusakbary syrusakbary merged commit fe3d4b6 into main Aug 21, 2024
63 checks passed
@syrusakbary syrusakbary deleted the issue-5024-app-list-sort branch August 21, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants