Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Add --print-rclone-config to "app volumes s3-credentials" #5022

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

theduke
Copy link
Contributor

@theduke theduke commented Aug 19, 2024

No description provided.

@theduke theduke requested a review from syrusakbary as a code owner August 19, 2024 17:16
@theduke theduke force-pushed the app-s3-credentials-print-rclone-config branch from 8d0cfb0 to 3bf7165 Compare August 19, 2024 22:13
@theduke theduke force-pushed the app-s3-credentials-print-rclone-config branch from 3bf7165 to e938057 Compare August 19, 2024 22:27
@theduke theduke requested a review from ayys August 19, 2024 22:28
Copy link
Member

@ayys ayys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could have a --outfile or --out flag to store the config in a file edge-<name>.rclone.config and then add a comment to the output letting the user know

something like,

[stderr] # You can append the app config to rclone by running this command:
[stderr] # wasmer app volumes s3-credentials --rclone-print >> edge-{app_name}.config
[stderr] # rclone --config  edge-{app_name}.config ls edge-{app_name}:/
[edge-{app_name}]
type = s3
provider = Other
acl = private
access_key_id = {access_key}
secret_access_key = {secret_key}
endpoint = {endpoint}

@syrusakbary syrusakbary merged commit 07b7f54 into main Aug 21, 2024
63 checks passed
@syrusakbary syrusakbary deleted the app-s3-credentials-print-rclone-config branch August 21, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants