Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow nested mounted paths in UnionFilesystem #5008

Merged
merged 15 commits into from
Aug 21, 2024
Merged

Allow nested mounted paths in UnionFilesystem #5008

merged 15 commits into from
Aug 21, 2024

Conversation

maminrayej
Copy link
Contributor

This PR adds support for nested mounted paths such as:

[fs]
"/app/a" = "a"
"/app/b" = "b"

when using the UnionFilesystem.

theduke
theduke reviewed Aug 13, 2024
View reviewed changes
Copy link
Contributor

@theduke theduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, but not very familiar with the union fs.

lib/virtual-fs/src/union_fs.rs Outdated Show resolved Hide resolved
syrusakbary
syrusakbary approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go once tests pass

@maminrayej maminrayej enabled auto-merge August 20, 2024 15:11
@maminrayej maminrayej disabled auto-merge August 20, 2024 15:24
@syrusakbary syrusakbary merged commit 9d03606 into main Aug 21, 2024
62 of 63 checks passed
@syrusakbary syrusakbary deleted the allow-nested-mounted-paths branch August 21, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arshia001 Arshia001 Arshia001 left review comments

@theduke theduke theduke left review comments

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maminrayej @syrusakbary @theduke @Arshia001