Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: use windows-sys instead of winapi #5001

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

ognevny
Copy link
Contributor

@ognevny ognevny commented Aug 10, 2024

Description

winapi has no updates for more than 3 years, while windows-sys is bindings maintained by microsoft devs

@ognevny ognevny requested a review from syrusakbary as a code owner August 10, 2024 11:47
@ognevny ognevny force-pushed the use-windows-sys branch 3 times, most recently from c0d7ccd to b91cede Compare August 10, 2024 14:28
@ognevny
Copy link
Contributor Author

ognevny commented Aug 10, 2024

looks like CI fail is not related to this PR

@syrusakbary
Copy link
Member

This is great, approving and merging. Thanks for moving this forward @ognevny!

@syrusakbary syrusakbary merged commit 56894ff into wasmerio:main Aug 11, 2024
62 of 63 checks passed
@ognevny ognevny deleted the use-windows-sys branch August 11, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants