Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple fixes for the journal to fix bootstrapping #4986

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Multiple fixes for the journal to fix bootstrapping #4986

merged 3 commits into from
Aug 15, 2024

Conversation

john-sharratt
Copy link
Contributor

No description provided.

theduke
theduke reviewed Aug 5, 2024
View reviewed changes
Copy link
Contributor

@theduke theduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get some high level comments on the major parts of the code in here so readers have an easier time following what's going on?

What are the types, what's the events field on StateDescriptor, , etc.

lib/journal/src/concrete/compacting.rs Outdated Show resolved Hide resolved
@theduke theduke enabled auto-merge (rebase) August 15, 2024 05:36
@theduke theduke disabled auto-merge August 15, 2024 05:49
@theduke theduke merged commit 4009eab into main Aug 15, 2024
57 checks passed
@theduke theduke deleted the fixes-for-journal-instaboot branch August 15, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theduke theduke theduke approved these changes

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@john-sharratt @theduke