Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount [fs] entries as additional mapped directories when running a lo… #4982

Merged
merged 5 commits into from
Aug 8, 2024

Conversation

Arshia001
Copy link
Member

…cal package

@theduke
Copy link
Contributor

theduke commented Jul 31, 2024

@Arshia001 there should probably be a test for this in the CLI integration tests?

Eg: start a static webserver , add a file ,fetch the file with an http client, make sure the file is as expected?

Copy link
Contributor

@maminrayej maminrayej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just needs a test that reads from, writes to, and creates file on the host filesystem.

@Arshia001 Arshia001 enabled auto-merge August 2, 2024 13:57
@Arshia001 Arshia001 merged commit dc8d5f7 into main Aug 8, 2024
63 checks passed
@Arshia001 Arshia001 deleted the feat/host-backed-webc-take-3 branch August 8, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants