New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: No string manipulation on `app.yaml` #4976

Merged

xdoardo merged 1 commit into main from deploy-no-string-manipulation

Jul 30, 2024

Contributor

xdoardo commented Jul 30, 2024

As per title.

Pieces of code that manually edited the app configuration as a raw string now use the appropriate calls to manipulate a serde_yaml::Value.


          fix(cli/deploy): No string manipulation on app.yaml

811f7bb

xdoardo requested a review from syrusakbary as a code owner

July 30, 2024 13:32

syrusakbary approved these changes

View reviewed changes

xdoardo merged commit 287bf8d into main

62 of 63 checks passed

xdoardo deleted the deploy-no-string-manipulation branch

July 30, 2024 14:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet