Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Introduce new auth subcommand #4968

Merged
merged 2 commits into from
Jul 31, 2024
Merged

CLI: Introduce new auth subcommand #4968

merged 2 commits into from
Jul 31, 2024

Conversation

xdoardo
Copy link
Contributor

@xdoardo xdoardo commented Jul 29, 2024

(Closes #4963, fixes RUN-376)

This PR introduces a new auth subcommand for login, logout and whoami, which previously were top-level ones.

In order not to have undocumented behaviour - such as keeping the top level commands but hidden in the help message - but to still push for the adoption of the new auth command in preparation of future releases, this PR also warns users of deprecation:

Screenshot 2024-07-29 at 17 18 57

@xdoardo xdoardo requested a review from syrusakbary as a code owner July 29, 2024 15:23
@xdoardo xdoardo requested a review from ayys July 29, 2024 15:24
@syrusakbary
Copy link
Member

I agree on uniting subcommands under auth, but I disagree on showing the warning and marking wasmer login wasmer whoami and other things as deprecated. They are shortcuts and should remain there

@xdoardo xdoardo requested a review from syrusakbary July 30, 2024 14:32
@xdoardo xdoardo merged commit f55ac06 into main Jul 31, 2024
63 checks passed
@xdoardo xdoardo deleted the cli-auth-command branch July 31, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI: Add auth command
2 participants