Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Try to fetch owner from app_id if necessary while deploying #4965

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

xdoardo
Copy link
Contributor

@xdoardo xdoardo commented Jul 26, 2024

(Closes #4957 , fixes RUN-372)

As per title: if no owner is supplied via CLI and there's no owner in the app.yaml, in the case that an app_id is present, the deploy command tries to fetch the app owner from the backend using the app_id.

@xdoardo xdoardo requested a review from syrusakbary as a code owner July 26, 2024 12:21
@xdoardo xdoardo requested a review from theduke July 26, 2024 12:21
@syrusakbary
Copy link
Member

Note: there can be no owner, or no owner and no name, or no name.

In general, if we have an app id, and there's a mismatch between the corresponding owner and name, then we need to update them both automatically and show that app.yaml has been updated in the stdout as information for the user.

@xdoardo xdoardo changed the title Try to fetch owner from app_id if necessary CLI: Try to fetch owner from app_id if necessary while deployin Jul 29, 2024
@xdoardo xdoardo changed the title CLI: Try to fetch owner from app_id if necessary while deployin CLI: Try to fetch owner from app_id if necessary while deploying Jul 29, 2024
@xdoardo xdoardo merged commit dae91a6 into main Jul 30, 2024
62 of 63 checks passed
@xdoardo xdoardo deleted the deploy-with-app-id branch July 30, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI: wasmer deploy: existing app not detected properly when no namespace specified
3 participants