Fix impossible relocation error in emit sdiv64 for singlepass compiler #4956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I add test like here : tests/compilers/issues.rs? |
|
Yes, we need a have a regression test to make sure it doesn't happen again. You can copy the one that you pointed at @ByteNacked |
|
As soon as we have the test we should be good to merge :) |
|
Minimized bug as possible, added test |
|
cc @syrusakbary |
xdoardo
approved these changes
Jul 30, 2024
|
It seems there's a small issue on one integration tests, but all tests are running well, so we just merged directly @ByteNacked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes reoccurring error
ImpossibleRelocation(Dynamic(DynamicLabel(0)))with singlepass compiler for aarch64 targetswhen generating sdiv64 binop.
Program which reproduce the bug bug.wat.zip.
See #4519 and comment for more info.
What's done
emit_cbz_label_farwhen emittingsdiv64binopemit_cbz_label_farmethod