Move WasmerConfig out of the registry_api crate and introduce a logout subcommand
#4955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntroduce a `logout` subcommand
xdoardo
changed the title
WasmerConfig out of the registry_api create and introduce a logout subcommandWasmerConfig out of the registry_api crate and introduce a logout subcommand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Closes #4951 and - hopefully - others login-related issues).
This PR does two things:
backend-apivsregistry-api). In order to achieve this, it moves theWasmerConfigtype out of theregistry-apicrate and into theclicrate. In turn, this allows to merge theApiOptsandWasmerEnvtypes. Rationale for doing this now: If you login, then attempt to login again it panics #4918 panics due to the runtime-inside-a-runtime quirk in turn due to the use of registry-api.logoutcommand.This PR is preventive, and should initially be used just to test the behaviour of the CLI after the induced changes.
In order to be sure that the issues #4918 and #4918 are solved by this PR, a windows-native test run must be executed.