Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes a panic caused on the recv_from path #4946

Merged
merged 4 commits into from
Jul 23, 2024
Merged

Fixes a panic caused on the recv_from path #4946

merged 4 commits into from
Jul 23, 2024

Conversation

john-sharratt
Copy link
Contributor

This is caused because the slices do not line up - its not been detected till now because UDP sockets are vary used

theduke
theduke approved these changes Jul 21, 2024
View reviewed changes
Copy link
Contributor

@theduke theduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a small regression test for this?

@john-sharratt john-sharratt enabled auto-merge July 23, 2024 12:38
@john-sharratt john-sharratt merged commit 49e60af into main Jul 23, 2024
62 checks passed
@john-sharratt john-sharratt deleted the fix-for-recv-from-panic branch July 23, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theduke theduke theduke approved these changes

@syrusakbary syrusakbary Awaiting requested review from syrusakbary syrusakbary is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@john-sharratt @theduke