Prevent unnecessary panics when compiling on x86_64 CPUs that dont support AVX or SSE4.2 #4928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In regards to the cargo-deny CI step, do you want me to upgrade that crate? It's kind of outside of the scope of my fix |
syrusakbary
approved these changes
Jul 15, 2024
|
Merging directly as the fail is not caused by this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
My company, Bitping, operates a distributed network of user devices to perform network tests and other types of work using WASM binaries. We use wasmer as the interpreter for these binaries and recently after an update one of our node operators with an AMD Turion II processor reported the following error at start up, which caused our application to fail to start.
This PR attempts to solve the panic by returning a Result instead if compilation fails on older x86_64 CPUs that dont support AVX or SSE4.2.
I've successfully compiled the package locally as well as run the compiler_singlepass tests, which all pass.