Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile wasmer-api crate to wasm32-unknown-unknown #4920

Merged
merged 8 commits into from
Jul 12, 2024
Merged

Conversation

xdoardo
Copy link
Contributor

@xdoardo xdoardo commented Jul 8, 2024

This patch resolves compiler errors arising when compiling the wasmer-api (a.k.a. backend-api) crate to wasm32-unknown-unknown targets.

The main complication was the explicit use of a type (Pin<Box<dyn Stream<Item = Result<Vec<DeployApp>, anyhow::Error>> + Send + Sync>>) that required a Sync that was not available in wasm32.

@xdoardo xdoardo requested a review from theduke July 8, 2024 11:31
lib/backend-api/src/client.rs Outdated Show resolved Hide resolved
lib/backend-api/src/query.rs Outdated Show resolved Hide resolved
@theduke theduke merged commit 53b5c3b into main Jul 12, 2024
62 checks passed
@theduke theduke deleted the backend-api-wasm32 branch July 12, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants