Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli/push): Push with name if available (+ CLI flag) #4912

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

xdoardo
Copy link
Contributor

@xdoardo xdoardo commented Jul 2, 2024

As of now, while users can push a package to a namespace without a version, they can't attach to it a name as well. This patch introduces the necessary infrastructure for the CLI to be able to push unversioned (as in, named, but without a version) packages to the registry.

For example, if a manifest such as the following

[package]
name = "my-namespace/my-package"
<no version> 
...

is found in the directory of the package to push, then the result of wasmer package push is to push to the registry a package bound to the identifier my-namespace/my-package but without a version. This can behaviour can also be enforced with the corresponding --name flag in the push subcommand.

This does not allow users to run unversioned packages, as no consensus on naming was reached yet - this means that, as of now, executing wasmer run my-namespace/my-package:<hash> will fail. Instead, users can run their package with wasmer run <hash>.

@xdoardo xdoardo requested a review from syrusakbary as a code owner July 2, 2024 15:57
@maminrayej maminrayej merged commit 461e9ff into main Jul 3, 2024
62 checks passed
@maminrayej maminrayej deleted the push-with-name branch July 3, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants