-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App create: Ask for framework before fetching templates #4897
App create: Ask for framework before fetching templates #4897
Conversation
I'm not that sure of doing it via framework instead of language as we indicated on the original issue (there will be many frameworks that we support, so language seems like a better initial filter). Any insights on why this was done this way? |
It works both ways, as maybe a language supports many framework for heterogeneous needs. But, in any case, the code is structured in a way such that if we want to filter by language first, the change is trivial. The only missing bit is from the backend (cc: @ayys), that should support calls to retrieve all languages and get templates filtered by language. |
I dont quite get why we select by framework first, because the framework list could just grow huge again eventually. Making the first step selecting the language seems much more sensible? |
Alright, agreed on filtering by language. Waiting for the backend API to implement it that way. |
nit: should there also be a option for when I want to view templates from another category/language/framework? |
Latest commit changes it to display languages first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussed with @xdoardo and lgtm 🚀
(attaching images as this is pretty much a design patch)
In order to speed up the CLI reducing the size of the data requested to the backend and to provide a better UX, we wanted to introduce a new mechanism to present available templates to users. Before, we presented a list of all the available templates to the user:
With this patch, the user first selects the framework they want and, after that, the actual template from the matching ones.