CLI: Use a channel to signal that the main fn is done #4860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syrusakbary
approved these changes
Jun 18, 2024
theduke
requested changes
Jun 18, 2024
theduke
approved these changes
Jun 20, 2024
xdoardo
deleted the
4859-cli-newly-intalled-signal-handler-impedes-normal-termination-of-the-program
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to solve #4859. Use a channel to notify the
setupthread that the main CLI function (deploy,tag,push..) is done and, in this case, should not wait for SIGINT to be received. Another approach could be that of simply calling.abort()on theJoinHandle.