Don't pass auth header when downloading a package #4838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Where this PR originates from? What is this trying to fix? I thought this was needed in the past for downloading the files |
theduke
approved these changes
Jun 12, 2024
|
(note: even if approved, please do not merge until resolving my question below) |
|
Context of the issue:
|
syrusakbary
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small patch removes the auth header passed to Wasmer's cdn when downloading a package. Of course, this does not remove the mandatory auth when interacting with the graphql endpoint, which is still necessary.
Furthermore, it makes the
--out-pathoptional, and in case the user does not give a value for the flag it uses$(pwd)/[email protected]or$(pwd)/hash.webcas a filename.