fix(cli): Respect owner in app.yaml during app resolution #4822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Namespaces Make the GetCurrentUser query only return a plain user without namespaces. Rename the current function/query to GetCurrentUserWithNamespaces, get_current_user_with_namespaces. This makes more sense , since the namespace query adds quite a lot of extra work.
The backend refactor that removed global aliases was not fully reflected in the CLI, breaking "wasmer app get" and similar commands that all back the reading the local app.yaml file. This commit * Removes the `Alias` variant of AppIdent, since there conceptually are no global aliases anymore, just domains * Makes the resolution respect the `owner` in the config * Falls back to trying to get the app by name with the current user as the owner
syrusakbary
approved these changes
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(cli): Fix app resolution - respect owner in config
The backend refactor that removed global aliases was not fully reflected
in the CLI, breaking "wasmer app get" and similar commands that all back
the reading the local app.yaml file.
This PR
Removes the
Aliasvariant of AppIdent, since there conceptually are no globalaliases anymore, just domains
Makes the resolution respect the
ownerin the configFalls back to trying to get the app by name with the current user as
the owner
Cleans up some related logic in the api crate
Note: we should add a way to retrieve apps by domain, but that requires additional backend support.
Closes #4818