CLI: app create - Template handling improvements #4805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xdoardo
approved these changes
Jun 4, 2024
|
Note: we should add a different step in here that improves timings:
That'll improve performance, because right now the cache time is just set to 15 minutes. |
syrusakbary
approved these changes
Jun 5, 2024
* Add fetch_all_app_templates() helper * Allow sorting of templates * Make AppTemplate serializable NOTE: requires a version bump due to a breaking api change
* Store templates in a local cache to speed up queries Currently caches for 15 mins * Load more templates
theduke
force-pushed
the
issue-4804-app-create-templates
branch
from
b8e3685 to
b8fec8a
Compare
|
Note, I improved the caching logic by : |
theduke
force-pushed
the
issue-4804-app-create-templates
branch
from
b8fec8a to
23224ba
Compare
* Always use the cache for a given period (1h) * If cache is older than that, just fetch the first page, and compare if no changes, then can re-use the cache * Otherwise, refetch all
theduke
force-pushed
the
issue-4804-app-create-templates
branch
from
23224ba to
6d7d761
Compare
syrusakbary
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a local template cache (currently 15 minutes), and fetches more templates
from the backend, currently up to 100.
Also sorts the templates by popularity now.
NOTE: we should really use dialoger::FuzzySelect to give users a search prompt,
but that currently conflicts with the custom stylings of the select items and
messes up the formatting.
(See console-rs/dialoguer#312)
Closes #4804