-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WASIX Test Suite #4780
base: main
Are you sure you want to change the base?
WASIX Test Suite #4780
Conversation
@@ -77,6 +77,7 @@ while read dir; do | |||
|
|||
cmd="cd $dir; \ | |||
$CC $CFLAGS $LDFLAGS -o main.wasm main.c; \ | |||
wasm-opt -O4 --asyncify -g --fpcast-emu main.wasm -o main.wasm -pa max-func-params@32; \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need --fpcast-emu
nor -pa max-func-params@32
here (at least for now on the current examples)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be:
wasm-opt -O4 --asyncify -g --fpcast-emu main.wasm -o main.wasm -pa max-func-params@32; \ | |
wasm-opt -O3 --asyncify -g main.wasm -o main.wasm; \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge the PR once the comments are addressed
This PR is an attempt to provide a test suite for WASIX.
NOTE: This PR is still a work in progress since many other code paths must be tested.