Only warn if needed #4749
Merged
Only warn if needed #4749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-sharratt
force-pushed
the
only-warn-if-needed
branch
from
dcded84 to
30514ee
Compare
|
I was thinking of implementing the same thing. I was going to check for the asyncify exports instead. Indeed, it's possible to have a WASIX module that hasn't had the asyncify pass performed on it and can't ever unwind. I guess the best course of action would be to check for both the asyncify exports and the wasix imports? |
|
Somewhat agree with both sides here:
|
syrusakbary
reviewed
May 26, 2024
syrusakbary
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch will suppress the stack corruption warnings if asyncify is not used and hence its not a problem. This is to prevent all the large number of warnings that are being generated.