Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poll for write-readiness after connecting a blocking socket #4732

Merged
merged 1 commit into from
May 22, 2024
Merged

Poll for write-readiness after connecting a blocking socket #4732

merged 1 commit into from
May 22, 2024

Conversation

Arshia001
Copy link
Member

No description provided.

@Arshia001 Arshia001 requested review from syrusakbary and theduke May 22, 2024 10:33
theduke
theduke approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@theduke theduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We should create a followup issue about returning the proper EINPROGRESS for non-blocking sockets as appropriate.

@syrusakbary syrusakbary merged commit dacf004 into main May 22, 2024
61 checks passed
@syrusakbary syrusakbary deleted the sock-poll-ready-after-connect branch May 22, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theduke theduke theduke approved these changes

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Arshia001 @theduke @syrusakbary