Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove clock_time_get instrumentation #4709

Merged
merged 3 commits into from
May 17, 2024
Merged

Remove clock_time_get instrumentation #4709

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4de7317
remove clock_time_get instrumentation
maminrayej May 17, 2024
0042ef8
Merge branch 'main' into remove-clock-instrumentation
maminrayej May 17, 2024
73d7613
put clock_time_get instrumentation behind a feature gate
maminrayej May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/wasix/src/syscalls/wasi/clock_time_get.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
use super::*;
use crate::syscalls::*;

// NOTE: This syscall is not instrumented since it will be logged too much,
// hence introducing too much noise to the logs.

/// ### `clock_time_get()`
/// Get the time of the specified clock
/// Inputs:
Expand All @@ -11,8 +14,6 @@ use crate::syscalls::*;
/// Output:
/// - `Timestamp *time`
/// The value of the clock in nanoseconds
//#[instrument(level = "trace", skip_all, fields(?clock_id, %precision), ret)]
#[instrument(level = "trace", skip_all, ret)]
maminrayej marked this conversation as resolved.
Show resolved Hide resolved
pub fn clock_time_get<M: MemorySize>(
mut ctx: FunctionEnvMut<'_, WasiEnv>,
clock_id: Snapshot0Clockid,
Expand Down
Loading