Use registry templates to create new app #4703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syrusakbary
reviewed
May 15, 2024
This was
linked to
issues
May 16, 2024
..and fix the cmake issue in CI
syrusakbary
reviewed
May 16, 2024
syrusakbary
reviewed
May 16, 2024
If a package with hash `x` was tagged with `namespace/name@version` and the user wants (or ends up trying) to tag the package with the same `namespace/name@version`, just conclude with a nop and don't send the tag to the backend
|
Do we have a static site template? |
syrusakbary
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title, this PR removes the old templating mechanism and institutes a new one using the registry templates, solving #4578.
Mandatory screenshot:
Side quests:
wasmer deploytowasmer app create(solves cli(deploy): Add creation flags #4701)new-package-nameis not used anymore and, as of now, thestatic-websitetemplate is not available from the registry (with that name, at least).