Fix calculation of stat.st_size in the presence of combined seeks and writes #4698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maminrayej
reviewed
May 15, 2024
There was a problem hiding this comment.
Looks reasonable to me. But for this PR to be more inline with other recent fixes to wasix and virtual-fs, I'd like to see a wasi-fyi test that fails before this PR and passes after, so we know this fixes the issue and prevents any future regressions of this sort.
|
@maminrayej technically, |
|
@Arshia001 we can add them in wasi-fyi for now and open PRs later, that's ok! |
|
@syrusakbary @maminrayej I added the test, can you please re-review and approve? |
maminrayej
approved these changes
May 15, 2024
syrusakbary
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.