redirect to child node in a different fs #4689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syrusakbary
reviewed
May 14, 2024
syrusakbary
approved these changes
May 14, 2024
|
@maminrayej This does not resolve #3575. (The test vector I provided originally does not throw an error message anymore and now needs to be invoked with Whatever this PR changes isn't even related to the initial sentence of that bug (readdir cookies not being stable over directory modifications), so I have no idea why you thought this PR would fix that issue. |
|
@jcaesar it was most probably a mistake in typing the issue number. I'll look into it and re-open the issue if that is the case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing logic in
mem_fsfor redirecting when resolving a child node that resides in a different fs.Resolves #3575.