Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] correct error message when app version is not found #4679

Merged
merged 1 commit into from
May 14, 2024

Conversation

ayys
Copy link
Member

@ayys ayys commented May 14, 2024

This PR corrects the error message reported when the app version is not found on registry.

@ayys ayys requested a review from theduke May 14, 2024 06:41
@theduke
Copy link
Contributor

theduke commented May 14, 2024

This fixes the bad error message, but does not close #4647 .

Getting logs with an app id should still work.

The issue is that the command uses Identifier, while most of the other commands use AppIdentOpts, which supports finding the app from an app.yaml in the local directory, ns/name, and app id.
Problem is that it doesn't support a specific app version, which Identifier supports.

But all of these variations should work.

@theduke
Copy link
Contributor

theduke commented May 14, 2024

Since the query takes an owner + namespace, the CLI can detect that it's an app id, and do a query to resolve the owner/name itself.

@theduke theduke merged commit b663584 into main May 14, 2024
61 checks passed
@theduke theduke deleted the fix-error-msg-unknown-package-version branch May 14, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants