Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): Better final messages for push, tag and publish #4662

Merged
merged 4 commits into from
May 10, 2024
Merged

feat(cli): Better final messages for push, tag and publish #4662

merged 4 commits into from
May 10, 2024

Conversation

xdoardo
Copy link
Contributor

@xdoardo xdoardo commented May 10, 2024 •
edited
Loading

This small PR edits the final messages shown to the user for the above-mentioned commands.
Resolves #4663.

@xdoardo xdoardo requested a review from syrusakbary as a code owner May 10, 2024 07:59
syrusakbary
syrusakbary reviewed May 10, 2024
View reviewed changes
lib/cli/src/commands/package/tag.rs Outdated Show resolved Hide resolved
lib/cli/src/commands/package/push.rs Outdated Show resolved Hide resolved
lib/cli/src/commands/package/push.rs Outdated Show resolved Hide resolved
@syrusakbary syrusakbary merged commit 50dec95 into main May 10, 2024
61 checks passed
@syrusakbary syrusakbary deleted the show-package-url-publish branch May 10, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the messages in the push/tag/publish/deploy commands
2 participants
@xdoardo @syrusakbary