New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store and restore hash from a compiled module #4654

Merged

syrusakbary merged 18 commits into main from store-hash-in-artifact

May 10, 2024

Contributor

maminrayej commented May 8, 2024 •

edited

Loading

This PR stores the module hash in the ModuleInfo as part of the Artifact, so later after loading the compiled module from the disk, we would have access to the module hash.

maminrayej added 2 commits

May 9, 2024 01:49


          store and restore hash from a compiled module

1287b3c


          fix dep features

6f46120

syrusakbary requested changes

View reviewed changes

Member

syrusakbary left a comment

Move ModuleHash into wasmer-types and reuse it here as well

syrusakbary reviewed

View reviewed changes

lib/api/src/js/module.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/types/src/module.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/types/src/module.rs Outdated Show resolved Hide resolved

maminrayej added 2 commits

May 9, 2024 17:11


          resolve comments

2b430b8


          Merge branch 'main' into store-hash-in-artifact

f013e15

syrusakbary reviewed

View reviewed changes

lib/api/Cargo.toml Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/api/src/js/module.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/api/src/jsc/module.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/api/src/jsc/module.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/api/src/module.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/api/src/module.rs Outdated Show resolved Hide resolved

syrusakbary requested changes

View reviewed changes

lib/api/src/module_info_polyfill.rs Outdated Show resolved Hide resolved

lib/api/src/sys/module.rs Outdated Show resolved Hide resolved

lib/types/src/module.rs Outdated Show resolved Hide resolved

lib/cli/src/commands/run/mod.rs Outdated Show resolved Hide resolved

lib/compiler/src/translator/module.rs Outdated Show resolved Hide resolved

maminrayej added 2 commits

May 9, 2024 19:52


          resolve comments

e456285


          resolve more comments

e03c1c2

syrusakbary reviewed

View reviewed changes

lib/api/src/js/module.rs Outdated Show resolved Hide resolved

maminrayej added 3 commits

May 9, 2024 20:26


          update wasmu files

6be6cc8


          resolve comments

ab59cb6


          bump up msrv

f6a2c9f

maminrayej marked this pull request as ready for review

May 9, 2024 17:51


          fix ci failure

589d45e

syrusakbary reviewed

View reviewed changes

lib/compiler/src/translator/environ.rs Outdated Show resolved Hide resolved


          add hash algorithm option to the engine

010625a

syrusakbary reviewed

View reviewed changes

lib/api/src/engine.rs Outdated Show resolved Hide resolved

maminrayej added 2 commits

May 10, 2024 16:11


          Merge branch 'main' into store-hash-in-artifact

430b398


          resolve comment

aa77730

syrusakbary requested changes

View reviewed changes

lib/api/src/sys/engine.rs Outdated Show resolved Hide resolved

lib/api/src/sys/engine.rs Outdated Show resolved Hide resolved

lib/api/src/sys/tunables.rs Outdated Show resolved Hide resolved

lib/api/src/sys/tunables.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/types/src/module_hash.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/types/Cargo.toml Outdated Show resolved Hide resolved

maminrayej added 2 commits

May 10, 2024 16:40


          undo breaking changes


          remove rand dep and move functions to wasix

75318f8

syrusakbary reviewed

View reviewed changes

lib/api/src/jsc/module.rs Outdated Show resolved Hide resolved

syrusakbary approved these changes

View reviewed changes

Member

syrusakbary left a comment

LGTM


          remove unnecessary mut

bd2adfe

syrusakbary enabled auto-merge

May 10, 2024 13:24


          fix jsc build

22c1935

syrusakbary reviewed

View reviewed changes

lib/cli/src/commands/inspect.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/cli/src/commands/validate.rs Outdated Show resolved Hide resolved


          remove unncessary hash options for validate and inspect

c8ddde5

syrusakbary merged commit 7621d61 into main

61 checks passed

syrusakbary deleted the store-hash-in-artifact branch

May 10, 2024 14:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet