Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert wasmer-wasix dependency to per project instead of workspace #4653

Merged
merged 1 commit into from
May 9, 2024

Conversation

maminrayej
Copy link
Contributor

Using wasmer-wasix as a workspace dependency causes trouble for the release script. So for now, this PR reverts the dependency back to a per project style.

@maminrayej maminrayej requested a review from syrusakbary as a code owner May 8, 2024 18:51
@syrusakbary
Copy link
Member

We can merge this, if we create another issue to improve the release script and start using workspace dependencies for this crate (and other one we had before as well)

Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved only with the condition of linking here the new issue (for refactoring build script and use workspace dependencies) prior to merging

@maminrayej maminrayej merged commit c110af6 into main May 9, 2024
61 checks passed
@maminrayej maminrayej deleted the post-release-v4.3.0-beta.1 branch May 9, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants