New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for using webc v3 #4651

Merged

maminrayej merged 10 commits into main from add-option-for-v3

May 9, 2024

Contributor

maminrayej commented May 8, 2024

This PR adds support for the USE_V3 env var. If set, the cli will download v3 version of a package.

maminrayej added 5 commits

May 8, 2024 19:51


          add option to use webc v3

f852dbc


          fix missing fields

79e5c2d


          remove debugs

69f6ac8


          fix naming

862f16b


          remove debug

85203dc

maminrayej changed the title ~~Add option for v3~~ Add option for using v3

maminrayej changed the title ~~Add option for using v3~~ Add option for using webc v3

Member

ayys commented May 8, 2024

btw I'd call the env var WASMER_USE_WEBCV3

Contributor Author

maminrayej commented May 8, 2024

btw I'd call the env var WASMER_USE_WEBCV3

You're right. That's better.

maminrayej added 2 commits

May 8, 2024 23:44


          fix tests

21e65f7


          fix more tests

4c1d311

syrusakbary approved these changes

View reviewed changes

Member

syrusakbary left a comment

This looks good from me, probably we need the review from @theduke as well

syrusakbary reviewed

View reviewed changes

lib/wasix/src/runtime/resolver/wapm_source.rs Outdated Show resolved Hide resolved

syrusakbary previously requested changes

View reviewed changes

Member

syrusakbary left a comment

Address env var comment

theduke previously requested changes

View reviewed changes

lib/wasix/src/runtime/resolver/wapm_source.rs Outdated Show resolved Hide resolved

lib/wasix/src/runtime/resolver/wapm_source.rs Outdated Show resolved Hide resolved


          move the decision to the cli

1e6a4f5

syrusakbary reviewed

View reviewed changes

lib/cli/src/commands/run/mod.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/cli/src/commands/run/wasi.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/wasix/src/runtime/resolver/wapm_source.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/cli/src/commands/run/wasi.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/wasix/src/runtime/resolver/wapm_source.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/wasix/src/runtime/resolver/wapm_source.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/wasix/src/runtime/resolver/wapm_source.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/wasix/src/runtime/resolver/wapm_source.rs Outdated Show resolved Hide resolved

maminrayej added 2 commits

May 9, 2024 17:23


          improve naming

0d81a1c


          fix typo

9710bda

maminrayej dismissed stale reviews from theduke and syrusakbary

May 9, 2024 14:52

Resolved.

syrusakbary approved these changes

View reviewed changes

maminrayej merged commit b669503 into main

61 checks passed

maminrayej deleted the add-option-for-v3 branch

May 9, 2024 15:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet