Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync modified timestamp upon creating the inode #4645

Merged
merged 1 commit into from
May 8, 2024
Merged

sync modified timestamp upon creating the inode #4645

merged 1 commit into from
May 8, 2024

Conversation

maminrayej
Copy link
Contributor

No description provided.

@maminrayej maminrayej changed the title sync modified time stamp upon creating the inode sync modified timestamp upon creating the inode May 8, 2024
@maminrayej maminrayej enabled auto-merge May 8, 2024 10:44
Arshia001
Arshia001 requested changes May 8, 2024
View reviewed changes
Copy link
Member

@Arshia001 Arshia001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we also handle the zero timestamps for creation and access time? I believe we should set those to be equal to the modification time if they're not available, since returning zero is still a bad idea.

@maminrayej maminrayej disabled auto-merge May 8, 2024 11:11
@maminrayej maminrayej enabled auto-merge May 8, 2024 11:14
Arshia001
Arshia001 approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@Arshia001 Arshia001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we also handle the zero timestamps for creation and access time? I believe we should set those to be equal to the modification time if they're not available, since returning zero is still a bad idea.

Let's do this in another PR.

@maminrayej maminrayej merged commit 8f578e8 into main May 8, 2024
61 checks passed
@maminrayej maminrayej deleted the fix-inode-out-of-sync-timestamp branch May 8, 2024 11:18
@maminrayej maminrayej mentioned this pull request May 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arshia001 Arshia001 Arshia001 approved these changes

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maminrayej @syrusakbary @Arshia001