Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add proxy support to the package download subcommand #4640

Merged
merged 4 commits into from
May 9, 2024

Conversation

maminrayej
Copy link
Contributor

In continuation with #4624, this PR adds proxy support to the wasmer package download subcommand.

@maminrayej maminrayej requested a review from syrusakbary as a code owner May 6, 2024 19:59
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address comment

@ayys
Copy link
Member

ayys commented May 7, 2024

Potential future changes: we will probably need to do the same for wasmer run (I think that uses a different code path to download the package).
Also, the code to upload file to google storage would also break I suppose? so we will need to add proxy there as well. (cc: @xdoardo since he is working on the publish stuff)

@maminrayej
Copy link
Contributor Author

Potential future changes: we will probably need to do the same for wasmer run (I think that uses a different code path to download the package).

The code path for wasmer run was covered in #4624 .

Also, the code to upload file to google storage would also break I suppose? so we will need to add proxy there as well

That's a good point. I can check that code path as well.

Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved once comment is addressed

@maminrayej maminrayej merged commit 124f76d into main May 9, 2024
61 checks passed
@maminrayej maminrayej deleted the proxy-support-for-package-download branch May 9, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants