Handle local package resolution #4638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syrusakbary
reviewed
May 6, 2024
syrusakbary
approved these changes
May 7, 2024
There was a problem hiding this comment.
Looks good for me, but I think since is touching Binary package will be better for @theduke to do the final approval
theduke
changed the title
theduke
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the way for handling a local package is the same as a local webc file. This will cause the code to rely on webc hash as a unique identifier in the resolution graph. But the cost of computing the hash for a local package is much higher than a local webc file since for the package, we must serialize the package to get the hash.
This PR adds a new code path for running a local package and uses the hash of the package path as its unique identifier in the dependency graph.