Support partial manifest fields #4630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes some fields of the `wasmer_config::package::Package` type non mandatory. In particular, `name`, `version` and `description` aren't mandatory anymore. This introduces *two ways* to describe unnamed packages - no `package` section in the manifest and `package` section with no `name` field in it, and a third kind of package in the package taxonomy, which I deliberately name, here _unversioned packages_, that is packages with a `name` (and any other field) but no `version`.
syrusakbary
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
name,versionanddescriptionfields of thePackagetype inwasmer_configoptional and deals with the cascading changes. This PR tackles #4626 and opens the way for #4621 and #4612.