Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reuse atom signatures #4627

Merged
merged 11 commits into from
May 3, 2024
Merged

reuse atom signatures #4627

merged 11 commits into from
May 3, 2024

Conversation

maminrayej
Copy link
Contributor

@maminrayej maminrayej commented Apr 29, 2024

This PR tries to reuse the atom signature (sha256 hash of the atom) in the manifest to prevent recomputing the hash for that atom.
This will be done in two steps:

  1. Add support for two hashing algorithms in ModuleHash, namely xxhash and sha256.
  2. Use sha256 for hashes of atoms in order to be able to reuse their signature.

@theduke
Copy link
Contributor

theduke commented Apr 29, 2024

Note: we'll want a validation function that validates all these invariants to be correct, and run that validation on webc upload in the future.

@maminrayej maminrayej marked this pull request as ready for review April 30, 2024 15:19
@maminrayej maminrayej merged commit cc6daca into main May 3, 2024
61 checks passed
@maminrayej maminrayej deleted the reuse-atom-signature branch May 3, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants