-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reuse atom signatures #4627
Merged
Merged
reuse atom signatures #4627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syrusakbary
reviewed
Apr 29, 2024
syrusakbary
reviewed
Apr 29, 2024
syrusakbary
reviewed
Apr 29, 2024
syrusakbary
reviewed
Apr 29, 2024
syrusakbary
reviewed
Apr 29, 2024
syrusakbary
reviewed
Apr 29, 2024
syrusakbary
reviewed
Apr 29, 2024
syrusakbary
reviewed
Apr 29, 2024
Note: we'll want a validation function that validates all these invariants to be correct, and run that validation on webc upload in the future. |
syrusakbary
approved these changes
Apr 30, 2024
syrusakbary
reviewed
Apr 30, 2024
syrusakbary
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to reuse the atom signature (sha256 hash of the atom) in the manifest to prevent recomputing the hash for that atom.
This will be done in two steps:
ModuleHash
, namelyxxhash
andsha256
.sha256
for hashes of atoms in order to be able to reuse their signature.