Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CLI): Pass the no_wait flag to Deploy #4623

Merged
merged 1 commit into from
Apr 29, 2024
Merged

fix(CLI): Pass the no_wait flag to Deploy #4623

merged 1 commit into from
Apr 29, 2024

Conversation

xdoardo
Copy link
Contributor

@xdoardo xdoardo commented Apr 26, 2024 •
edited
Loading

A small change to pass the no_wait flag given when using the create command to the deploy command in case it is called.

Also, rename:
autobump -> bump in deploy and publish
app_name -> name in create
deploy_app -> deploy in create

@xdoardo
fix(CLI): Pass the no_wait flag to Deploy
a0ef6e9 
This small patch also changes a couple names of CLI arguments to make
them more natural to the end user or reflect the internal names (e.g.
`autobump` -> `bump`).
@xdoardo xdoardo requested a review from syrusakbary as a code owner April 26, 2024 17:56
@xdoardo xdoardo requested a review from theduke April 29, 2024 07:10
@xdoardo xdoardo mentioned this pull request Apr 29, 2024
Closed
@theduke theduke merged commit a57cbb5 into main Apr 29, 2024
61 checks passed
@theduke theduke deleted the fix-create-no-wait-flag branch April 29, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theduke theduke theduke approved these changes

@syrusakbary syrusakbary Awaiting requested review from syrusakbary syrusakbary is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xdoardo @theduke