Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.3.0 alpha.1 leftover fixes #4617

Merged
merged 5 commits into from
May 8, 2024
Merged

4.3.0 alpha.1 leftover fixes #4617

merged 5 commits into from
May 8, 2024

Conversation

Arshia001
Copy link
Member

No description provided.

@Arshia001 Arshia001 requested a review from syrusakbary as a code owner April 25, 2024 14:07
@Arshia001 Arshia001 force-pushed the 4.3.0-alpha.1-leftover-fixes branch from 593e211 to 5cb7a99 Compare April 25, 2024 14:09
@Arshia001 Arshia001 enabled auto-merge April 25, 2024 14:10
theduke
theduke reviewed Apr 25, 2024
View reviewed changes
lib/config/Cargo.toml Outdated Show resolved Hide resolved
syrusakbary
syrusakbary requested changes Apr 25, 2024
View reviewed changes
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasmer-config should be a workspace dependency, not sure why we rolledback on that, but I don't think should be necessary

@Arshia001
Copy link
Member Author

@syrusakbary cargo refused to publish crates that depend on wasmer-config without a version specified in the crate's own Cargo.toml. I tried putting a version in the workspace Cargo.toml, but that didn't solve the problem, so I had to make this change to be able to publish.

@Arshia001
Copy link
Member Author

@syrusakbary we need to merge this at some point. Do you want to do it as is, or find a workaround for the crate version thing and include that in this PR?

@Arshia001 Arshia001 force-pushed the 4.3.0-alpha.1-leftover-fixes branch from ea6b67a to 3377910 Compare May 8, 2024 13:57
@syrusakbary syrusakbary disabled auto-merge May 8, 2024 14:26
@syrusakbary syrusakbary merged commit bebb859 into main May 8, 2024
55 of 56 checks passed
@syrusakbary syrusakbary deleted the 4.3.0-alpha.1-leftover-fixes branch May 8, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theduke theduke theduke left review comments

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Arshia001 @syrusakbary @theduke