Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module cache optimization round2 #4552

Merged
merged 4 commits into from
Apr 15, 2024
Merged

Module cache optimization round2 #4552

merged 4 commits into from
Apr 15, 2024

Conversation

john-sharratt
Copy link
Contributor

Improvements as follows:

  • Fixed the mmap accelerated module load which was not using mmap
  • Removed a needless copy of the module code which the module is archived (i.e. it was not fully zero copy)
  • Various other minor tweaks

@john-sharratt john-sharratt requested a review from theduke April 11, 2024 10:20
@john-sharratt john-sharratt changed the title Module cache optimization round Module cache optimization round2 Apr 11, 2024
@theduke theduke mentioned this pull request Apr 11, 2024
Closed
@syrusakbary
Copy link
Member

Merging manually as tests are blocked by one issue on the backend, and not really related to the Wasmer runtime

@syrusakbary syrusakbary merged commit 77c3d0e into master Apr 15, 2024
55 of 59 checks passed
@syrusakbary syrusakbary deleted the module-cache-optimization-round2 branch April 15, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theduke theduke theduke left review comments

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@john-sharratt @syrusakbary @theduke