Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes detected in the build #4542

Merged
merged 6 commits into from
Apr 5, 2024
Merged

Various fixes detected in the build #4542

merged 6 commits into from
Apr 5, 2024

Conversation

john-sharratt
Copy link
Contributor

Full list of fixes are at the bottom of this description, however these two in particular look like quite big ones....
Note: Basically the functions are not actually being invoked, thus they are unlikely to be working at all

warning: unused pinned boxed `futures::Future` trait object that must be used
   --> /prog/wasmer/lib/virtual-fs/src/union_fs.rs:443:25
    |
443 |                         ret.unlink();
    |                         ^^^^^^^^^^^^
    |
    = note: futures do nothing unless you `.await` or poll them
    = note: `#[warn(unused_must_use)]` on by default
warning: unused pinned boxed `futures::Future` trait object that must be used
    --> /prog/wasmer/lib/wasix/src/state/env.rs:1101:25
     |
1101 |                         f.copy_reference(Box::new(StaticFile::new(atom)));
     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = note: futures do nothing unless you `.await` or poll them
     = note: `#[warn(unused_must_use)]` on by default

Full list is here:

warning: unused imports: `borrow`, `collections`, `fmt`, `str`
  --> /prog/wasmer/lib/compiler/src/lib.rs:44:23
   |
44 |         pub use std::{borrow, boxed, collections, fmt, str, string, sync, vec};
   |                       ^^^^^^         ^^^^^^^^^^^  ^^^  ^^^
   |
   = note: `#[warn(unused_imports)]` on by default

warning: unused imports: `DeserializeError`, `SerializeError`
 --> /prog/wasmer/lib/compiler/src/engine/error.rs:3:24
  |
3 | pub use wasmer_types::{DeserializeError, ImportError, SerializeError};
  |                        ^^^^^^^^^^^^^^^^               ^^^^^^^^^^^^^^

warning: `wasmer-compiler` (lib) generated 2 warnings (run `cargo fix --lib -p wasmer-compiler` to apply 2 suggestions)
warning: unused import: `cranelift_codegen::print_errors::pretty_error`
 --> /prog/wasmer/lib/compiler-cranelift/src/trampoline/mod.rs:9:9
  |
9 | pub use cranelift_codegen::print_errors::pretty_error;
  |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

warning: unused import: `cranelift_codegen::Context`
  --> /prog/wasmer/lib/compiler-cranelift/src/trampoline/mod.rs:10:9
   |
10 | pub use cranelift_codegen::Context;
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused import: `FunctionBuilder`
  --> /prog/wasmer/lib/compiler-cranelift/src/trampoline/mod.rs:11:30
   |
11 | pub use cranelift_frontend::{FunctionBuilder, FunctionBuilderContext};
   |                              ^^^^^^^^^^^^^^^

warning: unused import: `ReturnMode`
  --> /prog/wasmer/lib/compiler-cranelift/src/translator/mod.rs:10:63
   |
10 | pub use self::func_environ::{FuncEnvironment, GlobalVariable, ReturnMode, TargetEnvironment};
   |                                                               ^^^^^^^^^^

warning: unused import: `self::func_state::FuncTranslationState`
  --> /prog/wasmer/lib/compiler-cranelift/src/translator/mod.rs:11:9
   |
11 | pub use self::func_state::FuncTranslationState;
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused import: `get_vmctx_value_label`
  --> /prog/wasmer/lib/compiler-cranelift/src/translator/mod.rs:14:5
   |
14 |     get_vmctx_value_label, irlibcall_to_libcall, irreloc_to_relocationkind,
   |     ^^^^^^^^^^^^^^^^^^^^^

warning: `wasmer-compiler-cranelift` (lib) generated 6 warnings (run `cargo fix --lib -p wasmer-compiler-cranelift` to apply 6 suggestions)
warning: unused imports: `EngineInner`, `Features`
  --> /prog/wasmer/lib/api/src/engine.rs:16:53
   |
16 | pub use wasmer_compiler::{Artifact, CompilerConfig, EngineInner, Features, Tunables};
   |                                                     ^^^^^^^^^^^  ^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

warning: `wasmer` (lib) generated 1 warning (run `cargo fix --lib -p wasmer` to apply 1 suggestion)
warning: unused pinned boxed `futures::Future` trait object that must be used
   --> /prog/wasmer/lib/virtual-fs/src/union_fs.rs:443:25
    |
443 |                         ret.unlink();
    |                         ^^^^^^^^^^^^
    |
    = note: futures do nothing unless you `.await` or poll them
    = note: `#[warn(unused_must_use)]` on by default

warning: `virtual-fs` (lib) generated 1 warning
warning: unused import: `arc::*`
  --> /prog/wasmer/lib/journal/src/concrete/mod.rs:27:9
   |
27 | pub use arc::*;
   |         ^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

warning: unused import: `boxed::*`
  --> /prog/wasmer/lib/journal/src/concrete/mod.rs:29:9
   |
29 | pub use boxed::*;
   |         ^^^^^^^^

warning: `wasmer-journal` (lib) generated 2 warnings (run `cargo fix --lib -p wasmer-journal` to apply 2 suggestions)
warning: `&` without an explicit lifetime name cannot be used here
  --> /prog/wasmer/lib/wasix/src/os/command/builtins/cmd_wasmer.rs:43:17
   |
43 |     const NAME: &str = "wasmer";
   |                 ^
   |
   = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
   = note: for more information, see issue #115010 <https://github.com/rust-lang/rust/issues/115010>
   = note: `#[warn(elided_lifetimes_in_associated_constant)]` on by default
help: use the `'static` lifetime
   |
43 |     const NAME: &'static str = "wasmer";
   |                  +++++++

warning: `&` without an explicit lifetime name cannot be used here
  --> /prog/wasmer/lib/wasix/src/runtime/resolver/wapm_source.rs:32:36
   |
32 |     pub const WASMER_DEV_ENDPOINT: &str = "https://registry.wasmer.wtf/graphql";
   |                                    ^
   |
   = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
   = note: for more information, see issue #115010 <https://github.com/rust-lang/rust/issues/115010>
help: use the `'static` lifetime
   |
32 |     pub const WASMER_DEV_ENDPOINT: &'static str = "https://registry.wasmer.wtf/graphql";
   |                                     +++++++

warning: `&` without an explicit lifetime name cannot be used here
  --> /prog/wasmer/lib/wasix/src/runtime/resolver/wapm_source.rs:33:37
   |
33 |     pub const WASMER_PROD_ENDPOINT: &str = "https://registry.wasmer.io/graphql";
   |                                     ^
   |
   = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
   = note: for more information, see issue #115010 <https://github.com/rust-lang/rust/issues/115010>
help: use the `'static` lifetime
   |
33 |     pub const WASMER_PROD_ENDPOINT: &'static str = "https://registry.wasmer.io/graphql";
   |                                      +++++++

warning: unused pinned boxed `futures::Future` trait object that must be used
    --> /prog/wasmer/lib/wasix/src/state/env.rs:1101:25
     |
1101 |                         f.copy_reference(Box::new(StaticFile::new(atom)));
     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = note: futures do nothing unless you `.await` or poll them
     = note: `#[warn(unused_must_use)]` on by default

@syrusakbary syrusakbary merged commit 9fe37d2 into master Apr 5, 2024
59 checks passed
@syrusakbary syrusakbary deleted the various-fixes branch April 5, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants